Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(model): make Model.bulkWrite() with empty array and ordered false not throw an error #13770

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

vkarpov15
Copy link
Collaborator

Fix #13664

Summary

@JavaScriptBach is right that the fact that bulkWrite([], { ordered: false }) throwing an error is a bit of a rough patch in the API. Especially since bulkWrite([]) (no ordered: false) does not throw an error.

Examples

@vkarpov15 vkarpov15 added this to the 6.12.0 milestone Aug 22, 2023
@JavaScriptBach
Copy link
Contributor

Thanks for this fix!

@vkarpov15 vkarpov15 merged commit 4f79ce2 into 6.x Aug 24, 2023
34 checks passed
@AbdelrahmanHafez AbdelrahmanHafez deleted the vkarpov15/gh-13664-2 branch August 24, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants